-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-16233 make script batches pick up where they left off #17236
VACMS-16233 make script batches pick up where they left off #17236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Getting and setting state for a series of script runs should be useful going forward, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no issues here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Approved!
…e-they-left-off
Description
Relates to #16233
This makes it possible to resume the menu altering script from any given point if the script dies like it did the first two attempts to run it on prod.
This creates the ability for the execution of batched scripts to keep state using the Drupal State API to keep track of the last successfully completed batch and pick up where it left off on subsequent runs.
On prod the script ran out of memory processing run number 118. It is most likely that 118 ran successfully and it was actually 119 that failed, but to be safe, we will run it from 117 on by doing the following
ddev drush state:set script_library__va_gov_vamc_get_system_menus 117
drush scr ./scripts/content/VACMS-16233-reorder-vamc-menu-items.php
Testing done
Screenshots
QA steps
Login to Tugboat dashboard
Open the php terminal
run
ddev drush state:set script_library__va_gov_vamc_get_system_menus 117
run
drush scr ./scripts/content/VACMS-16233-reorder-vamc-menu-items.php
Validate output looks like:
When complete, validate that VA Spokane health care has been re-ordered (the first item in the resumed
validate that VA St Cloud menu has been rearranged (to rule out off-by-one error)
validate VA Lebanon has been rearranged (to rule out off by one error on other end - the last one in the list)
Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing
Is this PR blocked by another PR?
DO NOT MERGE
Does this PR need review from a Product Owner
Needs PO review
CMS user-facing announcement
Is an announcement needed to let editors know of this change?